fix(app-jshint): improve jshint usage #482
Conversation
|
Instead of defining |
|
I actually did at first, but then I was worried about defining globals for all the server files. Do you think that it should not cause a problem? |
|
How about a |
|
Well that's what we're currently doing for the client side jshint. I guess we could have a jshint specifically for tests. Not really sure what it should be called. Maybe .jshintrc-spec? We could use the "extends" option in jshint to extend the default jshint file, and make it a bit more dry. |
|
That sounds like a good thing... would you be so kind as to point it out to me? I can't seem to find "extends" in the docs for |
|
I don't see any documentation on it, but you can see that angular.js is using it in their .jshintrc |
|
Awesome! Done. |
kingcody
force-pushed
the
fix/jshint
branch
2 times, most recently
from
00a7543 to
13ebc85
Compare
kingcody
changed the title
|
@DaftMonk please take a look at |
Changes: - Update jshint task in `Gruntfile.js` to include `serverTest` - Add `server/.jshintrc-spec` that extends `server/.jshintrc` with spec globals - Use `"latedef": "nofunc"` instead of `"latedef": true` in `server/.jshintrc` - Add assertion for `jshint` task in generator tests for `defaultOptions` - Fix pre exsisting lint errors in `server` and `client` - Change `getEmail()` in `client/app/account/settings/settings.controller` to use `user` arg and not `$scope.user` Closes angular-fullstack#463, angular-fullstack#486
fix(app-jshint): improve jshint usage
Changes:
Gruntfile.jsto includeserverTestserver/.jshintrc-specthat extendsserver/.jshintrcwith spec globals"latedef": "nofunc"instead of"latedef": trueinserver/.jshintrcjshinttask in generator tests fordefaultOptionsserverandclientgetEmail()inclient/app/account/settings/settings.controllerto useuserarg and not$scope.userCloses #463, #486